Skip to content

fix(config): ensure the actually used config file is correct, fix single config file being detected as duplicated, better test coverage #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bearomorphism wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(config): ensure the actually used config file is correct, fix single config file being detected as duplicated, better test coverage #1784

bearomorphism wants to merge 1 commit into from
+150 −104

Conversation

@bearomorphism
Copy link
Collaborator

@bearomorphism bearomorphism commented Jan 12, 2026 •
edited
Loading

This is an improvement a fix based on #1773

  • Improved test coverage of multiple config file warning
  • Ensured the consistency of actually used config file, which is not always the first element of the candidates

Closes #1787

@codecov
Copy link

codecov bot commented Jan 12, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.96%. Comparing base (aa82b98) to head (5e7e008).
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1784   +/-   ##
=======================================
  Coverage   97.95%   97.96%           
=======================================
  Files          60       60           
  Lines        2646     2648    +2     
=======================================
+ Hits         2592     2594    +2     
  Misses         54       54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bearomorphism
bearomorphism commented Jan 13, 2026
View reviewed changes
@bearomorphism bearomorphism force-pushed the fix-multiple-config-2 branch 2 times, most recently from ca0df9a to 12214ab Compare January 13, 2026 12:01
@bearomorphism bearomorphism changed the title fix(config): ensure the actually used config file is correct, better test coverage fix(config): ensure the actually used config file is correct, fix single config file being detected as duplicated, better test coverage Jan 13, 2026
@bearomorphism bearomorphism force-pushed the fix-multiple-config-2 branch 4 times, most recently from 600da2d to cf9c66f Compare January 13, 2026 14:52
@bearomorphism bearomorphism mentioned this pull request Jan 13, 2026
Open
2 tasks
@Lee-W
Copy link
Member

Lee-W commented Jan 14, 2026

In case your uv project doesn’t have a lockfile or any uv specific config, you can still force poe to use the uv executor like so:

Yep, agree this might not be necessary. No strong opinion on this one. Will leave it to @noirbizarre

@bearomorphism
Copy link
Collaborator Author

bearomorphism commented Jan 14, 2026

In case your uv project doesn’t have a lockfile or any uv specific config, you can still force poe to use the uv executor like so:

Yep, agree this might not be necessary. No strong opinion on this one. Will leave it to @noirbizarre

Are you replying to #1795 🤔

bearomorphism
bearomorphism commented Jan 14, 2026
View reviewed changes
docs/config/configuration_file.md
Comment on lines -31 to -33
!!! tip
For Python projects, it's recommended to add your Commitizen configuration to `pyproject.toml` to keep all project configuration in one place.

Copy link
Collaborator Author

@bearomorphism bearomorphism Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should recommend pyproject.toml or .cz.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woile woile Awaiting requested review from woile woile is a code owner

@Lee-W Lee-W Awaiting requested review from Lee-W Lee-W is a code owner

@noirbizarre noirbizarre Awaiting requested review from noirbizarre noirbizarre is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pr-status: wait-for-review type: bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Single configuration file detected as duplicate since 4.11.2

3 participants

@bearomorphism @Lee-W